Replace ament_target_dependencies with target_link_libraries #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <acordero@clutterbot.com>
ahcorde
commented
Jun 11, 2025
Comment on lines
+66
to
+67
| ${CMAKE_INSTALL_PREFIX}/lib/controller | ||
| ${CMAKE_INSTALL_PREFIX}/../webots_ros2_driver/lib/controller |
|
@ahcorde Thank you for the PR. I believe we still need to use ament_target_dependencies for Humble and Jazzy? |
Best thing you can do it's to create branches for each distro as we are doing in core packages and configure mergify to backport features or fixes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ament_target_dependenciesis deprecated onkiltedand removed inrolling, It will require a new release onrolling.