Skip to content

Fixes iOS caller ID display in performStartCallAction #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

Fixes iOS caller ID display in performStartCallAction #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bde8688
feat: parse caller Id (client/number) in performStartCallAction
cybex-dev Sep 2, 2025
e8ffdee
docs: update CHANGELOG
cybex-dev Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## Next release

* Fix: [iOS] show caller number or interpretted client name for performStartCallAction
* Docs: update CHANGELOG

## 0.3.2+1

* Fix: [iOS] Missed call notifications now show caller name (or full number) on title, and "Missed call" text in body. [Issue #299](https://github.com/cybex-dev/twilio_voice/issues/299)
Expand Down
10 changes: 9 additions & 1 deletion ios/Classes/SwiftTwilioVoicePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,10 +930,18 @@ public class SwiftTwilioVoicePlugin: NSObject, FlutterPlugin, FlutterStreamHand
}

self.sendPhoneCallEvents(description: "LOG|StartCallAction transaction request successful", isError: false)

var callerName: String?
if(handle.contains("client:")) {
let clientName = handle.replacingOccurrences(of: "client:", with: "")
callerName = self.clients[clientName]
} else {
callerName = handle;
}

let callUpdate = CXCallUpdate()
callUpdate.remoteHandle = callHandle
callUpdate.localizedCallerName = self.clients[handle] ?? self.clients["defaultCaller"] ?? self.defaultCaller
callUpdate.localizedCallerName = callerName ?? self.clients["defaultCaller"] ?? self.defaultCaller
callUpdate.supportsDTMF = false
callUpdate.supportsHolding = true
callUpdate.supportsGrouping = false
Expand Down