forked from ethereum/execution-spec-tests
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(fw): Add and integrate consume engine types #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
spencer-tb
wants to merge
38
commits into
danceratopz:main
Choose a base branch
from
spencer-tb:feat/consume/engine-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(fw): Add and integrate consume engine types #31
spencer-tb
wants to merge
38
commits into
danceratopz:main
from
spencer-tb:feat/consume/engine-improvements
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-pytest-command
If blocktest is unavailable exit pytest before the test session starts. If --single-test is supported test individual fixtures using that, otherwise test per fixture file, not per single fixture.
…ate-pytest-command To get changes from feat(pytest): use node id as fixture name ethereum#342.
This reverts commit 74efd5e.
…ate-pytest-command This adds: ethereum#341, ethereum#342, ethereum#347.
Co-authored-by: danceratopz <danceratopz@gmail.com>
…ate-pytest-command
…validFixtureBlock
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR aims to start creating a structure within
src/ethereum_test_tools/for usage within consume.Its predominant aim is to define a types file specifically for the engine api spec, that can be used within the
tests_consume/test_via_engine_api.pyEEST simulator (and potentially many more). This allows us to:FixtureEngineNewPayloadetc types, apprehending a future deprecation of the hive blockchain fixture format. We can delete these with ease.Key Changes
FixtureBlocktype. Changes incl:base_fee->base_fee_per_gas,reciept_root->reciepts_root,bloom->logs_bloom,mix_digest->prev_randao,hash->block_hash,FixtureBlock:txs->transactionssrc/ethereum_test_tools/rpc/*intosrc/ethereum_test_tools/consume/.src/ethereum_test_tools/consume/types.py, containing engine new payload and execution payload types, specific to the engine api fork version - aligning cleanly with the spec.FixtureBlockinto their respectiveEngine<fork>.NewPayloadV<version>dataclasses.Engine<fork>.NewPayloadV<version>dataclasses to the correct json representation, expected withinengine_rpc.py.Remaining Todos
FixtureBlockto a correct engine new payload json representation:test_consume_via_engine.pyandengine_rpc.py, cleaning up more code.Other Considerations
coinbasetofeeRecipentto align more with the PoS terminology (also makes the engine spec cleaner).numbertoblock_number.