Skip to content

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Mar 1, 2025

Right now the package pulls two versions of redis, one 0.29 from a direct dependency and 0.28 from deadpool-redis.

I think it's worth placing a separate Cargo.toml for deadpool examples.

UPD: Was deadpool-redis added here by mistake? 4274f73

@daniel7grant
Copy link
Owner

You are correct, I added deadpool-redis to the regular dependencies by mistake. I usually do updates using cargo-outdated and cargo add with the specific version but it sometimes turn into errors. If you could move deadpool-redis to the dev-dependencies, I could merge it and release a new version.

This change would fix the deadpool examples too, right? I'm not sure if you can add separate Cargo.toml files for examples, these are built as separate binaries but use the same dependency set. Can you explain this?

@negezor
Copy link
Contributor Author

negezor commented Mar 1, 2025

This change would fix the deadpool examples too, right? I'm not sure if you can add separate Cargo.toml files for examples, these are built as separate binaries but use the same dependency set. Can you explain this?

I think you can see how it's done here https://github.com/async-graphql/examples and https://github.com/async-graphql/async-graphql

@daniel7grant
Copy link
Owner

Oh I see. My issue with this is that a major value for built-in examples are that I can use them as simple end-to-end tests with cargo test --examples. If you don't have any duplicate issues in your production builds anymore then I'd consider this a fix and merge it.

@negezor
Copy link
Contributor Author

negezor commented Mar 2, 2025

If you don't have any duplicate issues in your production builds anymore then

Yep 😄

@daniel7grant daniel7grant merged commit ec951a7 into daniel7grant:master Mar 2, 2025
8 checks passed
@daniel7grant
Copy link
Owner

Cheers, I deployed version 0.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants