support more then 34 devices #601
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmegidish
requested changes
Aug 24, 2025
| case entry := <-deviceEntryChan: | ||
| deviceList.DeviceList = append(deviceList.DeviceList, entry) | ||
| case <-time.After(100 * time.Millisecond): | ||
| return deviceList, nil |
There was a problem hiding this comment.
is 100ms the only way to know we have reached the last device? such absolute timing can be random when dealing with services. what do you think?
There was a problem hiding this comment.
em.. do you have some better way?
| } | ||
| }() | ||
| var deviceList = DeviceList{ | ||
| DeviceList: make([]DeviceEntry, 0, 40), |
There was a problem hiding this comment.
why was 34 a limit? and why put 40 as the new limit?
There was a problem hiding this comment.
In most conditions, phone number is bellow 40 (from my experience).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.