Add ubuntu ISO to CI #669
Add ubuntu ISO to CI #669
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables the building of Ubuntu ISOs in the CI/CD pipeline by uncommenting previously disabled workflow steps. It adds the Ubuntu unattended ISO build process, checksum calculation, and automated upload to the server alongside the existing Debian ISO workflow.
- Uncommented Ubuntu ISO build, checksum, and upload steps in the GitHub Actions workflow
- Added automated upload of Ubuntu unattended ISO and its checksum to the SSH server
- Integrated Ubuntu ISO processing into the existing release workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/release.yml
Outdated
| target: ${{ secrets.ISO_SSH_PATH }} | ||
| overwrite: true | ||
| env: | ||
| SHASUM_UBUNTU_UNATTENDED: ${{ steps.shasum-ubuntu-unattended.outputs.SHASUM_UBUNTU_UNATTENDED }} |
There was a problem hiding this comment.
The SHASUM_UBUNTU_UNATTENDED environment variable is removed from the 'Write release content' step but is still referenced in the 'Upload Ubuntu unattended to SSH server' step. This creates an inconsistency where the shasum is calculated but not included in the release content.
.github/workflows/release.yml
Outdated
| username: ${{ secrets.ISO_SSH_USER }} | ||
| key: ${{ secrets.ISO_SSH_PRIVATE_KEY }} | ||
| port: ${{ secrets.SSH_PORT }} | ||
| source: "SHASUM_UBUNTU_UNATTENDED|./images/Dappnode-*-ubuntu-*-unattended.iso" |
There was a problem hiding this comment.
The source parameter appears to reference 'SHASUM_UBUNTU_UNATTENDED' as a file path, but this is an environment variable containing the checksum value, not a file. The scp-action expects file paths in the source parameter.
Add build of ubuntu ISO unattended, calculate its shashum and upload both files to dappnode server