Update rocketpool commands in AppService to support v.1.18.1 release #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the following updates to AppService to be compatible with rocketpool v.1.18.1 release:
node can-set-withdrawal-addresscmd tonode can-set-primary-withdrawal-addressnode can-deposit amount min-fee saltcmd toapi node can-deposit amount min-fee salt use-express-ticketand sets theuse-express-ticketargument to false by defaultnode deposit amount min-node-fee salt use-credit-balance submitcmd tonode deposit amount min-node-fee salt use-credit-balance use-express-ticket submitand sets theuse-express-ticketargument to false by defaultgetNodeCanRegister()function and theNodeCanRegister.tstype, as these were not being used (frontend always uses thecanRegisterNode()function).Special request
👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇
Please add the
hacktoberfest-acceptedlabel to this PR before merging so it counts as an open source contribution to this year's Hacktoberfest 🙏👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆