Adding WorkflowTaskOptions and use it instead of TaskOptions #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
artur-ciocanu
force-pushed
the
gh-1199
branch
from
2489f57 to
462b98a
Compare
Contributor
Author
|
@artursouza @cicoyle @salaboy could you please take a look. These are breaking changes, but I think we can afford to have them so we could cleanup the Dapr Workflow public API and remove any Durable Task specific classes. Please take a look and let me know your thoughts. Thank you! |
Collaborator
|
100% I will look in detail Monday morning |
Contributor
Author
|
@artursouza and @cicoyle sorry to insist, could you please take a look and let me know if things are looking good. |
cicoyle
reviewed
Jan 28, 2025
sdk-workflows/src/main/java/io/dapr/workflows/WorkflowContext.java
Outdated
Show resolved
Hide resolved
cicoyle
reviewed
Jan 28, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
One comment on naming changes, but otherwise lgtm
Contributor
Author
@cicoyle I have added a comment regarding |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@artursouza and @cicoyle I have addressed review comments. Could you please approve. Thank you. |
artur-ciocanu
changed the title
cicoyle
approved these changes
Jan 30, 2025
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 7, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 20, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 20, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 21, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
akkie
pushed a commit
to akkie/java-sdk
that referenced
this pull request
Feb 23, 2025
Signed-off-by: Christian Kaps <ck-github@mohiva.com>
dapr-bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
* Add actor testcontainer tests Signed-off-by: Christian Kaps <ck-github@mohiva.com> * adding auto config Signed-off-by: Christian Kaps <ck-github@mohiva.com> * updating ActorClient Signed-off-by: Christian Kaps <ck-github@mohiva.com> * registering? Signed-off-by: Christian Kaps <ck-github@mohiva.com> * updating actors test and actorruntime Signed-off-by: Christian Kaps <ck-github@mohiva.com> * updating ActorRuntime Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Adding WorkflowTaskOptions and use it instead of TaskOptions (#1200) Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Fix formatting issues Signed-off-by: Christian Kaps <ck-github@mohiva.com> * adding spring boot workflows integration (#1195) Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Register workflows and acitivities using instances along classes (#1201) Signed-off-by: Christian Kaps <ck-github@mohiva.com> * feat: Adding basic HTTPEndpoint configuration support in testcontainers module (#1210) * feat: Adding basic HTTPEndpoint configuration support in testcontainers module Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> * feat: #1209 Adding test for HTTPEndpoint in testcontainers module Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> --------- Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * fixing actors IT test and messaging IT with app-health-checks Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Some minor cleanup Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> --------- Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * adding license headers + adding wait for actors in test Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Some minor cleanup Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> --------- Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Picks a port for DaprActorITS for test containers to avoid conflict. Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Add app health check support to Dapr Testcontainer (#1213) * Add app health check support to Dapr Testcontainer Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Some minor cleanup Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Move waiting to beforeEach, it looks more natural Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> --------- Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: Christian Kaps <ck-github@mohiva.com> * using random port thanks to @artur-ciocanu Signed-off-by: Christian Kaps <ck-github@mohiva.com> * Update TestRestController.java Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> * Update DaprActorsIT.java Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> * Update DaprContainer.java Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Christian Kaps <ck-github@mohiva.com> Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Co-authored-by: Laurent Broudoux <laurent.broudoux@gmail.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR accomplishes the following:
SagaOptiontoSagaOptionsthis is to ensure it aligns with the rest of the APIs.NewWorkflowOptiontoNewWorkflowOptionssimilar to the above it is to make sure API is consistentWorkflowExecutionOptionsthis replacesTaskOptions.TaskOptionsis a Durable Task specific class and we would like to have something that is native to Dapr Java SDK.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1199
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: