Another set of Maven version, properties and plugin improvements #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
============================================
+ Coverage 76.91% 78.50% +1.59%
- Complexity 1592 1934 +342
============================================
Files 145 216 +71
Lines 4843 5872 +1029
Branches 562 659 +97
============================================
+ Hits 3725 4610 +885
- Misses 821 924 +103
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@dapr/maintainers-java-sdk could you please review this PR. It has a lot of files, but these are primarily related to moving Maven properties and plugins around for a better organization and ensure proper long term maintenance. @javier-aliaga could you please also take a look! Thank you! |
| <surefire.version>3.2.2</surefire.version> | ||
| <junit-bom.version>5.11.4</junit-bom.version> | ||
| <snakeyaml.version>2.0</snakeyaml.version> | ||
| <testcontainers.version>1.21.3</testcontainers.version> |
Contributor
There was a problem hiding this comment.
Why we are downgrading testcontainers version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is another PR to cleanup the Maven mess that we have. The goal is the same, trying to add some order and ensure it will be easier to upgrade and maintain all the dependencies long term. I also cleaned up the Docker in Docker setup, since we don't need that. It is working just fine with the default Docker that is installed in GitHub Actions Runner.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: