#3182. Add tests for augmenting function parameters with import prefix #3440
+357
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 9, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, but the descriptions need to say 'type annotation'.
| /// the augmented function. | ||
| /// | ||
| /// @description Checks that it is not an error if an augmentation uses a | ||
| /// parameter name with a library prefix. |
Member
There was a problem hiding this comment.
I don't understand that, and I can't see anything which could be called "a parameter name with a library prefix"...
Member
There was a problem hiding this comment.
Ah! It's the type annotation of the parameter which has an import prefix. So the description should be adjusted to say that.
| /// getter, or setter may be augmented to provide a body or add metadata. | ||
| /// | ||
| /// @description Checks that it is not an error if an augmentation uses a | ||
| /// parameter name with a library prefix. |
sgrekhov
changed the title
Contributor
Author
|
Thanks! Updated. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.