Skip to content

Don't write trailing commas in split catch clauses. #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Don't write trailing commas in split catch clauses. #1572

merged 1 commit into from
Oct 4, 2024

Conversation

munificent
Copy link
Member

Apparently the language doesn't allow them. Who knew?

Fix #1570.

@munificent
Don't write trailing commas in split catch clauses.
f5caa5c 
Apparently the language doesn't allow them. Who knew?

Fix #1570.
kallentu
kallentu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I never knew this?

@munificent
Copy link
Member Author

munificent commented Oct 4, 2024 •
edited
Loading

Same. 🤷

@munificent munificent merged commit 0945c9d into main Oct 4, 2024
7 checks passed
@munificent munificent deleted the catch-comma branch October 4, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallentu kallentu kallentu approved these changes

@natebosch natebosch Awaiting requested review from natebosch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split catch clause incorrectly has trailing comma
2 participants
@munificent @kallentu