Skip to content

fix(ok_http): trust manager init #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

fix(ok_http): trust manager init #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa30c1
fix(ok_http): trust manager init
denysvitali Oct 8, 2025
1e3e05e
Merge remote-tracking branch 'upstream/master' into pr/1830
brianquinlan Oct 15, 2025
6e7c0b6
Add a CHANGELOG.md entry
brianquinlan Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/ok_http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- `OKHttpClient` supports client certificates.
- Support `package:web_socket` 1.0.0.
- Set `minSdk=24`.
- Add a missing call to `TrustManagerFactory.init`.

## 0.1.0

Expand Down
7 changes: 4 additions & 3 deletions pkgs/ok_http/lib/src/ok_http_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ class OkHttpClient extends BaseClient {
if (!configuration.validateServerCertificates) {
trustManagers[0] = _allAllTrustManager;
} else {
final tms = bindings.TrustManagerFactory.getInstance(
bindings.TrustManagerFactory.getDefaultAlgorithm())!
.getTrustManagers()!;
final tmf = bindings.TrustManagerFactory.getInstance(
bindings.TrustManagerFactory.getDefaultAlgorithm())!
..init(null);
final tms = tmf.getTrustManagers()!;
if (tms.length != 1) {
throw StateError('unexpected XXX');
}
Expand Down
Loading