Initial draft of a dismissible widget #8054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Sep 13, 2024
sigurdm
reviewed
Sep 13, 2024
sigurdm
reviewed
Sep 13, 2024
isoos
requested changes
Sep 24, 2024
isoos
approved these changes
Sep 25, 2024
sigurdm
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hmm, not sure I might have a SASS formatter that took some liberties 🙈 I can look into fixing that sometime -- or we can consider adopting something like it :/
Hmm, until it's dismissed the content is a bit jumpy.. Ideally, we should make the announcement banner cover some our margin, so that the page doesn't jump whether it's visible or not. The animation was only because it always starts hidden.