Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Sep 13, 2024

  • Reuses existing remove package logic, with the following updates:

    • reordering delete operations, in order to prevent information loss if the process fails mid-deletion,
    • also updates replacedBy fields if they are referencing the moderated package,
    • also deleted AuditLogRecord entities, otherwise the integrity check fails on them, (we could update the integrity checks to accept ModertedPackage existence in such cases though)
    • also adds previously deleted versions to the moderated package entity's list
  • Deleting package version is simpler in comparison, it needs to remove only a few references.

  • Deleting moderated publisher or user is implemented separately, left TODO for them.

@isoos isoos requested review from jonasfj and sigurdm September 13, 2024 11:07
@isoos isoos merged commit 1e3830b into dart-lang:master Sep 16, 2024
32 checks passed
@isoos isoos deleted the moderated-remove branch September 16, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants