Skip to content

Increase version limit for package already reaching 1000. #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Increase version limit for package already reaching 1000. #8058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e2ebc
Increase version limit for package already reaching 1000.
isoos Sep 16, 2024
f78b0a1
Update app/lib/package/overrides.dart
isoos Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/lib/package/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,9 +1139,11 @@ class PackageBackend {
package = Package.fromVersion(newVersion);
}

if (package!.versionCount >= maxVersionsPerPackage) {
final maxVersionCount = maxVersionsPerPackageOverrides[package!.name] ??
maxVersionsPerPackage;
if (package!.versionCount >= maxVersionCount) {
throw PackageRejectedException.maxVersionCountReached(
newVersion.package, maxVersionsPerPackage);
newVersion.package, maxVersionCount);
}

if (package!.deletedVersions != null &&
Expand Down
5 changes: 5 additions & 0 deletions app/lib/package/overrides.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,8 @@ bool isDartDevPublisher(String? publisherId) {
if (publisherId.endsWith('.google.com')) return true;
return false;
}

/// Overriding the default maximum number of the allowed package version counts.
const maxVersionsPerPackageOverrides = <String, int>{
'masamune': 1100, // last updated: 2024-09-16
};
Loading