Skip to content

Dark mode link hover: increase brightness instead lower opacity. #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Dark mode link hover: increase brightness instead lower opacity. #8494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e363b9
Dark mode link hover: increase brightness instead lower opacity.
isoos Jan 24, 2025
588bae2
Refactor styles into _base.scss
isoos Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/web_css/lib/src/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,13 @@
.displayed-in-light-theme {
display: none !important;
}

a {
&:hover {
opacity: 1.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have opacity other than 1?

Copy link
Collaborator Author

@isoos isoos Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the version tab icons have it on 0.7 by default (but uneffected as they are on the element). However, in this case this is to counter the main rule here:
https://github.com/dart-lang/pub-dev/blob/master/pkg/web_css/lib/src/_base.scss#L98-L100

I shall move that out to a separate light-theme/dark-theme styles so we don't need the override.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL.

filter: brightness(120%);
}
}
}

@mixin elevated-content-border {
Expand Down
Loading