Skip to content

Remove isolates from the analyzer service. #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Remove isolates from the analyzer service. #8509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb327d
Remove isolates from the analyzer service.
isoos Jan 30, 2025
fcebef7
Revert never
isoos Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 8 additions & 45 deletions app/lib/service/entrypoint/analyzer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import '../../task/backend.dart';
import '../../tool/neat_task/pub_dev_tasks.dart';

import '../download_counts/backend.dart';
import '_isolate.dart';

final Logger logger = Logger('pub.analyzer');

Expand All @@ -34,56 +33,20 @@ class AnalyzerCommand extends Command {
Future<void> run() async {
envConfig.checkServiceEnvironment(name);
await withServices(() async {
final worker =
await startWorkerIsolate(logger: logger, entryPoint: _workerMain);
registerScopeExitCallback(worker.close);
await downloadCountsBackend.start();
await taskBackend.start();
registerScopeExitCallback(() => taskBackend.stop());

final indexBuilder = await startWorkerIsolate(
logger: logger,
entryPoint: _indexBuilderMain,
kind: 'index-builder',
);
registerScopeExitCallback(indexBuilder.close);
setupPeriodTaskSchedulers();
// TODO: rewrite this loop to have a start/stop logic
scheduleMicrotask(searchBackend.updateSnapshotInForeverLoop);

if (activeConfiguration.exportedApiBucketName != null) {
final apiExporterIsolate = await startWorkerIsolate(
logger: logger,
entryPoint: _apiExporterMain,
kind: 'api-exporter',
);
registerScopeExitCallback(apiExporterIsolate.close);
await apiExporter!.start();
registerScopeExitCallback(() => apiExporter!.stop());
}

await runHandler(logger, analyzerServiceHandler);
});
}
}

Future _workerMain(EntryMessage message) async {
message.protocolSendPort.send(ReadyMessage());

await downloadCountsBackend.start();
await taskBackend.start();
registerScopeExitCallback(() => taskBackend.stop());

setupPeriodTaskSchedulers();

// wait indefinitely
await Completer().future;
}

Future _indexBuilderMain(EntryMessage message) async {
message.protocolSendPort.send(ReadyMessage());
await downloadCountsBackend.start();
await searchBackend.updateSnapshotInForeverLoop();
}

Future _apiExporterMain(EntryMessage message) async {
message.protocolSendPort.send(ReadyMessage());
await downloadCountsBackend.start();
await apiExporter!.start();
registerScopeExitCallback(() => apiExporter!.stop());

// wait indefinitely
await Completer().future;
}
Loading