Skip to content

Emit changelog excerpt only in the email and not on pub CLI. #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Emit changelog excerpt only in the email and not on pub CLI. #8938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/lib/package/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,6 +1130,8 @@ class PackageBackend {
}) async {
final sw = Stopwatch()..start();
final uploadMessages = <String>[];
// messages that are sent in the email but not returned as upload messages to the pub client
final additionalEmailMessages = <String>[];
final newVersion = entities.packageVersion;
final [currentDartSdk, currentFlutterSdk] = await Future.wait([
getCachedDartSdkVersion(lastKnownStable: toolStableDartSdkVersion),
Expand Down Expand Up @@ -1176,7 +1178,7 @@ class PackageBackend {
changelogContent: entities.changelogAsset?.textContent,
);
if (changelogExcerpt != null && changelogExcerpt.isNotEmpty) {
uploadMessages
additionalEmailMessages
.add('Excerpt of the changelog:\n```\n$changelogExcerpt\n```');
}

Expand Down Expand Up @@ -1279,7 +1281,10 @@ class PackageBackend {
displayId: agent.displayId,
authorizedUploaders:
uploaderEmails.map((email) => EmailAddress(email)).toList(),
uploadMessages: uploadMessages,
uploadMessages: [
...uploadMessages,
...additionalEmailMessages,
],
);
final outgoingEmail = emailBackend.prepareEntity(email);

Expand Down