Refactor + separately test the instance deletion logic in task scheduling #9097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
requested changes
Dec 1, 2025
isoos
force-pushed
the
task-loop-delete-instances
branch
2 times, most recently
from
e0e8250 to
3de24fd
Compare
Collaborator
Author
|
PTAL: I've updated the code as we've discussed - removed the events, fixed the logic (old test pass), and using a full list of instances. |
isoos
force-pushed
the
task-loop-delete-instances
branch
from
3de24fd to
135b26b
Compare
jonasfj
reviewed
Dec 3, 2025
isoos
force-pushed
the
task-loop-delete-instances
branch
from
135b26b to
c77f148
Compare
…ing tracking state. (dart-lang#9082)
jonasfj
reviewed
Dec 4, 2025
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
jonasfj
approved these changes
Dec 4, 2025
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Member
|
I suggest we ship this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.