Skip to content

Conversation

@parlough
Copy link
Member

No description provided.

@parlough
Copy link
Member Author

The one docker test will fail until that stable is updated to 3.7.

Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once CI is green

@domesticmouse
Copy link
Member

Docker CI is upset?

Dockerfile:8
--------------------
   6 |     WORKDIR /app
   7 |     COPY pubspec.* ./
   8 | >>> RUN dart pub get
   [9](https://github.com/dart-lang/samples/actions/runs/13294088051/job/37121671121?pr=228#step:6:10) |     
  10 |     # Copy app source code and AOT compile it.
--------------------
ERROR: failed to solve: process "/bin/sh -c dart pub get" did not complete successfully: exit code: 1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13294088073

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.909%

Totals Coverage Status
Change from base Build 12570372430: 0.0%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

@auto-submit
Copy link

auto-submit bot commented Feb 13, 2025

autosubmit label was removed for dart-lang/samples/228, because This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 2 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@ericwindmill ericwindmill merged commit 9f4e82e into main Feb 13, 2025
23 checks passed
@ericwindmill ericwindmill deleted the feat/dart-3-7-format branch February 13, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants