Skip to content

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Jun 4, 2025

No description provided.

@aurexav aurexav added the U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic label Jun 4, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Darwinia Chain Jun 4, 2025
@aurexav aurexav requested a review from Copilot June 4, 2025 14:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Deprecate use of sp-std by removing it from dependencies and replacing its APIs with core/alloc imports across various crates.

  • Remove sp-std entries in Cargo.toml and std feature lists.
  • Add extern crate alloc where needed and replace sp_std imports with core or alloc.
  • Update no_std modules to depend on alloc and core crates appropriately.

Reviewed Changes

Copilot reviewed 85 out of 85 changed files in this pull request and generated no comments.

Show a summary per file
File Description
precompile/state-storage/src/lib.rs Add alloc for tests and switch comment to // core
precompile/state-storage/Cargo.toml Remove sp-std dependency
precompile/assets/src/tests.rs Replace sp_std::str::from_utf8 with alloc::str
precompile/assets/src/mock.rs Replace sp_std::prelude::* with alloc::vec::Vec
precompile/assets/src/lib.rs Add alloc for tests; import core conversions
precompile/assets/Cargo.toml Remove sp-std entries
pallet/staking/src/lib.rs Add alloc imports; remove sp_std use
pallet/staking/src/benchmarking.rs Remove sp_std::prelude::*
pallet/staking/Cargo.toml Remove sp-std entries
pallet/ethtx-forwarder/src/mock.rs Remove sp_std::prelude::*
pallet/ethtx-forwarder/src/lib.rs Add alloc imports; remove sp_std::vec::Vec
pallet/ethtx-forwarder/Cargo.toml Remove sp-std entries
pallet/deposit/src/lib.rs Add alloc imports; remove sp_std::prelude::*
pallet/deposit/src/benchmarking.rs Remove sp_std::prelude::*
pallet/deposit/Cargo.toml Remove sp-std entries
pallet/account-migration/src/lib.rs Add alloc imports; remove sp_std::prelude::*
pallet/account-migration/src/benchmarking.rs Remove sp_std::prelude::*
pallet/account-migration/Cargo.toml Remove sp-std entries
Cargo.toml Remove top-level sp-std dependency
.maintain/pallet-weight-template.hbs Replace sp_std::marker::PhantomData with core import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant