implement display rotation #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AberDerBart
changed the title
|
wait, something went wrong with my git here, this is not the proper commit |
AberDerBart
force-pushed
the
main
branch
2 times, most recently
from
807cf2e to
cbfa5c2
Compare
|
so, this should be the correct version |
|
wow, it still wasn't the correct version, how emberassing. Now I double checked and tested it. |
|
Sorry, I totally forgot you! I will check this out tomorrow. |
Any plans to merge this? It would be very helpful for my project. :) |
CardboardDog
suggested changes
Aug 29, 2025
| memset(p->buffer, 0, p->bufsize); | ||
| } | ||
|
|
||
| inline void ssd1306_set_rotation(ssd1306_t *p, rotation_t rotation) { |
There was a problem hiding this comment.
in the header this is defined as a standard void but here it's inline. if you want it to be inline, just define it as a static inline in the header.
| p->rotation = rotation; | ||
| } | ||
|
|
||
| void rotate_coordinates(ssd1306_t *p, uint32_t* x, uint32_t* y) { |
|
|
||
| void rotate_coordinates(ssd1306_t *p, uint32_t* x, uint32_t* y) { | ||
| uint32_t tmp_x = *x; | ||
| if(p->rotation == ROT_90) { |
There was a problem hiding this comment.
switch case instead of if/else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Adds a
rotationattribute tossd1306_tthat can be set viassd1306_set_rotationto change the orientation of any further draw requests. Note thatwidthandheightstill correspond to the original orientation.