Add KillCaller feature to test server for CLI crash recovery testing #4146
+292
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
jefferycheng1,
kanterov,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
varundeepsaini
force-pushed
the
ft/server-crash-acceptance
branch
from
89e1011 to
3a3b6f5
Compare
Contributor
Author
|
@denik could you please review this pr |
varundeepsaini
force-pushed
the
ft/server-crash-acceptance
branch
2 times, most recently
from
debc6c8 to
bcc288c
Compare
varundeepsaini
force-pushed
the
ft/server-crash-acceptance
branch
from
bcc288c to
ba053c3
Compare
Contributor
Author
|
@denik can you please queue the integration tests |
Contributor
Author
|
@denik bump ^^ |
denik
reviewed
Dec 30, 2025
Collaborator
|
Commit: 1ad08e2
19 interesting tests: 18 KNOWN, 1 SKIP
Top 28 slowest tests (at least 2 minutes):
|
Signed-off-by: Varun Deep Saini <varun.23bcs10048@ms.sst.scaler.com>
Contributor
Author
|
@denik Had a few questions,
|
Contributor
That's a good idea.
yes. simple mutex would work.
I was thinking of more general request matcher that can match requests based on payload substring. Then we won't need predefined sequence and also be more reliable in case of unexpected retries. |
Contributor
Author
|
@denik I can add another field for the regex string, and kill all the requests which have the body matching that regex does that work with what idea you had ? (i would still like to keep the int field as well, for easier use) |
Contributor
In this PR, let's keep your counter approach. Body matching is just an idea for a separate feature. |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4140
Changes
Add
KillCalleroption to test server that terminates the CLI process when specific endpoints are hit. This enables testing crash recovery scenarios likebundle deployinterrupted mid-execution.KillCallerspecifies how many times to kill before allowing normal responses, enabling retry/recovery testing.Why
Enables testing CLI crash recovery scenarios (e.g.,
bundle deployinterrupted mid-execution).Tests
Added
acceptance/selftest/kill_caller/tests.