Unexport errors returned by the filer package #4156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Dec 18, 2025
Collaborator
|
Commit: 543e578
19 interesting tests: 18 KNOWN, 1 SKIP
Top 27 slowest tests (at least 2 minutes):
|
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Dec 18, 2025
|
|
||
| _, _, err = testcli.RequireErrorRun(t, ctx, "fs", "cat", path.Join(tmpDir, "dir1")) | ||
| assert.ErrorAs(t, err, &filer.NotAFile{}) | ||
| assert.ErrorIs(t, err, fs.ErrInvalid) |
Contributor
There was a problem hiding this comment.
unrelated to this PR, but is fs.ErrInvalid a correct error to use? The docs say "invalid argument", implies bad arguments passed to the function, not an issue with remote object being a wrong type.
Contributor
Author
There was a problem hiding this comment.
Good point. The fs package doesn't have a better alternative. But if we need one, we could add a few constants to libs/filer for more specific checks.
denik
reviewed
Dec 18, 2025
| switch { | ||
| case errors.Is(err, fs.ErrNotExist): | ||
| return NoSuchDirectoryError{path: absPath} | ||
| return noSuchDirectoryError{path: absPath} |
Contributor
There was a problem hiding this comment.
why replace fs.ErrNotExists with noSuchDirectoryError which pretends to be fs.ErrNotExist ?
People checking Is() will not see the difference.
Contributor
Author
There was a problem hiding this comment.
It normalizes the string Error() to be the same.
Contributor
There was a problem hiding this comment.
IMO this is a not a good thing. Adding common prefix is fine but replacing original error string entirely obscures underlying issue and hinders debugging.
(Unrelated to this PR, since this is happening on main as well).
andrewnester
approved these changes
Jan 2, 2026
Collaborator
|
Commit: 7aa738a
27 interesting tests: 18 KNOWN, 5 FAIL, 3 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some call sites depended on the underlying type of the error. All callers can rely on error equivalence with the
fs.Err*errors instead. The next step is to include the underlying errors in case callers need access to additional error details. This can use the error wrapping/unwrapping pattern.Tests
Unit tests pass.