Add ipykernel to default template #4164
Merged
+9
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes - Added ipykernel to dev dependencies in default template's pyproject.toml - Fixed outdated comment in conftest.py (removed reference to 'tests under resources/') - Updated acceptance test outputs for default-python, lakeflow-pipelines, and pydabs templates ## Why ipykernel enables Jupyter notebook support with the project's virtual environment, which is essential for the exploratory notebooks included in the template. The conftest comment was outdated and misleading. ## Investigation Confirmed that databricks.sdk.runtime.spark already works correctly in the template: - Unit tests properly use databricks.sdk.runtime.spark - pytest --collect-only is fast (~0.05s) and doesn't eagerly connect - DBR 15+ compatibility works via validateSession() - The eager initialization in conftest.py serves real purposes (compute config, version validation) and should be kept ## Tests - All template acceptance tests pass - Verified pytest --collect-only behavior - Tested on Python 3.9-3.13 - Tested with both classic and serverless compute
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Dec 19, 2025
libs/template/templates/default/template/{{.project_name}}/tests/conftest.py
Outdated
Show resolved
Hide resolved
lennartkats-db
changed the title
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
force-pushed
the
template-ipykernel-conftest
branch
from
003801f to
c3fb66d
Compare
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 3b4d85e
21 interesting tests: 18 KNOWN, 2 FAIL, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6e6ae46
27 interesting tests: 18 KNOWN, 4 FAIL, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds ipykernel to the
defaulttemplate and derived templates, which makes DB Connect notebooks work out of the box in Cursor / VS Code. It also fixes a stale comment.Tests
uv-installed environment. This new template now makes the UI show "Databricks Connect enabled" in the bottom status bar