Skip to content

Conversation

@samikshya-db
Copy link
Collaborator

@samikshya-db samikshya-db commented Dec 29, 2025

Description

  • 4 things that is improved with respect to telemetry :
    • Common object mapper across telemetry use-case (This is already thread safe and is expensive to create, i.e., good tor re-use)
    • MakeflushIntervalMillis config same across both telemetry clients (un-auth and auth)
    • Clear connection param cache when connection is closed : this was a memory leak before
    • Rather than creating a scheduledExecutor for each telemetry client, we share it across a factory.

Testing

  • unit tests

Additional Notes to the Reviewer

  • When the LAST connection to a host is closed, all pending telemetry events for that host are flushed across all prior connections (since they all shared the same TelemetryClient). i.e., If you have 5 connections to host-A, closing connections 1-4 does nothing (just decrements refCount). Only when you close connection 5 (the last one) does the flush occur, sending all accumulated telemetry from all 5 connections.

NO_CHANGELOG=true

@samikshya-db samikshya-db changed the title [PECOBLR-1408] [PECOBLR-1407] Address telemetry code audit comments- part1 [PECOBLR-1408] [PECOBLR-1407] [PECOBLR-1409] Address telemetry code audit comments- part1 Dec 29, 2025
@samikshya-db samikshya-db changed the title [PECOBLR-1408] [PECOBLR-1407] [PECOBLR-1409] Address telemetry code audit comments- part1 [PECOBLR-1408] [PECOBLR-1407] [PECOBLR-1409][PECOBLR-1411] Address telemetry code audit comments- part1 Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant