Skip to content

Commit 1332a43

Browse files
Revert "more verbose logging for type conversion fail"
This reverts commit 6481851.
1 parent 6481851 commit 1332a43

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/databricks/sql/backend/sea/result_set.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ def _convert_json_types(self, row: List[str]) -> List[Any]:
9292
converted_row = []
9393

9494
for i, value in enumerate(row):
95-
column_name = self.description[i][0]
9695
column_type = self.description[i][1]
9796
precision = self.description[i][4]
9897
scale = self.description[i][5]
@@ -104,7 +103,7 @@ def _convert_json_types(self, row: List[str]) -> List[Any]:
104103
converted_row.append(converted_value)
105104
except Exception as e:
106105
logger.warning(
107-
f"Error converting value '{value}' to {column_type} in column {column_name}: {e}"
106+
f"Error converting value '{value}' to {column_type}: {e}"
108107
)
109108
converted_row.append(value)
110109

src/databricks/sql/backend/sea/utils/conversion.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,13 @@ def convert_value(
155155
return value
156156

157157
converter_func = SqlTypeConverter.TYPE_MAPPING[sql_type]
158-
if sql_type == SqlType.DECIMAL:
159-
precision = kwargs.get("precision", None)
160-
scale = kwargs.get("scale", None)
161-
return converter_func(value, precision, scale)
162-
else:
163-
return converter_func(value)
158+
try:
159+
if sql_type == SqlType.DECIMAL:
160+
precision = kwargs.get("precision", None)
161+
scale = kwargs.get("scale", None)
162+
return converter_func(value, precision, scale)
163+
else:
164+
return converter_func(value)
165+
except (ValueError, TypeError, decimal.InvalidOperation) as e:
166+
logger.warning(f"Error converting value '{value}' to {sql_type}: {e}")
167+
return value

0 commit comments

Comments
 (0)