fix test_closing_connection_closes_commands
#584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Contributor
|
Hi @jprakash-db, could you please take a look as this fix is intended for the main branch. |
jayantsing-db
approved these changes
Jun 5, 2025
jprakash-db
reviewed
Jun 9, 2025
… instead of unittest primitives Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
to allow keeping the test inside ClientTestSuite Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
jprakash-db
approved these changes
Jun 10, 2025
Contributor
jprakash-db
left a comment
jprakash-db
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently,
test_closing_connection_closes_commandsis incorrect because:closedbut does not use them distinctly in thesubTests. The intention is likely to set them as the initial state ofhas_been_closed_server_side, based on the comment.Mocked, so when we check the final value ofhas_been_closed_server_side, it may extract an attribute that does not exist. This assertion will pass even if we do not sethas_been_closed_server_sidetoTruein ourclose()in theResultSet. This is because the attribute is created as a new mock on being accessed, and mocks are by-default truthy. In order to test this, even if we change the assertion toself.assertTrue(mock_result_set_class.return_value.random_attr), the test will pass, despiterandom_attrnot existing on the type.How is this tested?
Related Tickets & Documents
N/A