[Vis Tools] Remove population filter

[juliawu]

The population filter chart option often leads to buggy behavior, so the decision has been made to remove this option. This PR removes this filter.

Before:

After:

[gemini-code-assist]

Summary of Changes

Hello @juliawu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically removes the 'population filter' chart option from the visualization tools. This change addresses reported buggy behavior associated with the feature by eliminating its user interface, underlying data filtering logic, state management, and associated analytics tracking. The removal simplifies the codebase and improves the stability of the charting functionality by removing a problematic component.

Highlights

• Removal of Population Filter UI: The 'Filter by population' input fields and their associated labels have been completely removed from the plot options interface in plot_options.tsx, aligning the user interface with the decision to deprecate this feature.
• Data Filtering Logic Removed: The core data filtering mechanism that used popBounds to filter chart points based on population ranges has been removed from scatter_data_utils.ts and chart_loader.tsx, ensuring that data is no longer filtered by population bounds.
• State and Context Cleanup: All related state variables, context properties, and utility functions for lowerBound and upperBound have been removed from context.ts and util.ts, simplifying the application's state management and removing unused code.
• Analytics Tracking Updates: Google Analytics event tracking for the population filter option has been removed from ga_events.ts and ga_events.test.tsx, ensuring that no events are fired for a non-existent feature and cleaning up analytics definitions.
• URL Parameter Cleanup: The logic for parsing and updating URL hash parameters related to lowerBound and upperBound has been removed from util.ts and util.test.ts, preventing the persistence of deprecated filter settings in URLs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully removes the population filter feature, which was reported as buggy. The changes are comprehensive, touching upon UI elements, state management, data handling, and tests. The removal of the population filter logic from plot_options.tsx, context.ts, chart_loader.tsx, and scatter_data_utils.ts is well-executed. Corresponding updates to tests and constants are also correctly handled. The code is cleaner and the buggy feature is now gone. The changes are solid and I have no further comments.