-
Notifications
You must be signed in to change notification settings - Fork 115
Automated Integration Test Goldens Update from CI #5877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Automated Integration Test Goldens Update from CI #5877
Conversation
…233-a32a-0341cc50d82a)
Summary of ChangesHello @datacommons-robot-author, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated update of golden files for integration tests, ensuring that the test suite reflects the latest data and configuration changes. The updates primarily involve advancing dates in chart configurations, refining statistical variable specifications, and a substantial refactoring of topic classifications and chart blocks in certain test cases. These changes are crucial for maintaining the accuracy and relevance of automated integration tests. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily updates startDate and highlightDate values in various chart_config.json files, advancing them by one year (e.g., 2024 to 2025, 2020 to 2021, 2015 to 2016). It also includes minor precision adjustments to float values in debug_info.json files. A significant portion of the changes involves the removal of numerous chart blocks and their associated statistical variables from chart_config.json files, specifically impacting data related to 'Wildfire Emissions by Pollutant', various causes of death, mortality rates, and detailed population demographics. Review comments highlight that these removals, particularly for causes of death and wildfire emissions, represent a substantial reduction in test case scope and coverage, suggesting potential underlying issues with data availability or processing.
I am having trouble creating individual review comments. Click here to see my feedback.
server/integration_tests/test_data/e2e_date_range/lifeexpectancyinusstatesinthelast5years/chart_config.json (186-345)
A large number of charts and data variables related to causes of death have been removed in this update. For example, charts for 'Diseases of the Circulatory System', 'Causes of Female Mortality', and many others are gone. This represents a significant reduction in the scope of this test case. While this is an automated update, such a drastic change might point to an underlying issue with data availability or processing for these statistical variables. This could be an unintended side effect of other changes.
server/integration_tests/test_data/demo_feb2023/query_2/chart_config.json (130-190)
The chart block for 'Wildfire Emissions by Pollutant' and its associated statistical variables have been removed. This reduces the coverage of this test golden. This might be an unintended consequence of upstream data or code changes.
This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log