feat(datasets): add Atom feed link to search page #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a link to the datasets Atom feed on the search page. The link includes current search filters, allowing users to subscribe to filtered search results via their RSS reader. Requires opendatateam/udata#3578 for filter support on the Atom endpoint.
bjperson
requested review from
ThibaudDauce,
maudetes and
nicolaskempf57
as code owners
Contributor
|
@agarrone this is a screenshot of the changes. What do you think ? 
There are some technical changes to do but I think we should wait for PO approval before |
Contributor
|
Thank-you for the PR. |
Contributor
|
When moving the code to |
Move Atom feed link from page to SearchPage component as requested. Uses BrandedButton with RiRssLine icon, positioned next to sort control. URL built from nonFalsyParams for reactive filter support. Requires opendatateam/udata#3578 for filter support on the Atom endpoint.
Author
|
Thanks for the review! I've moved the button to SearchPage.vue next to the sort control, using nonFalsyParams and BrandedButton with proper href for accessibility. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a link to the datasets Atom feed on the search page. The link includes current search filters, allowing users to subscribe to filtered search results via their RSS reader.
Requires opendatateam/udata#3578 for filter support on the Atom endpoint.