Skip to content

fix: hydratation mismatches #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ThibaudDauce wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: hydratation mismatches #835

ThibaudDauce wants to merge 1 commit into from

Conversation

@ThibaudDauce
Copy link
Contributor

@ThibaudDauce ThibaudDauce commented Dec 22, 2025

No description provided.

@nicolaskempf57
Copy link
Contributor

nicolaskempf57 commented Dec 23, 2025

I think we should wrap NuxtLoadingIndicator in ClientOnly to deal with all its hydration mismatches. Also we can work on a better loading state if we want

@ThibaudDauce
Copy link
Contributor Author

ThibaudDauce commented Dec 23, 2025

I think we should wrap NuxtLoadingIndicator in ClientOnly to deal with all its hydration mismatches. Also we can work on a better loading state if we want

From my testing, it doesn't change anything to wrap NuxtLoadingIndicator in ClientOnly…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolaskempf57 nicolaskempf57 nicolaskempf57 approved these changes

@maudetes maudetes Awaiting requested review from maudetes maudetes is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThibaudDauce @nicolaskempf57