Skip to content

fix: business attribute side nav bar missing tab #14184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

fix: business attribute side nav bar missing tab #14184

merged 3 commits into from
Jul 29, 2025

Conversation

kartikey-visa
Copy link
Contributor

No description provided.

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 23, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 23, 2025
@yoonhyejin yoonhyejin requested a review from david-leifker July 23, 2025 18:10
@david-leifker david-leifker requested review from chriscollins3456 and removed request for david-leifker July 25, 2025 13:23
chriscollins3456
chriscollins3456 approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! thanks for this

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Jul 29, 2025
@asikowitz
Copy link
Collaborator 

We detected that the Electron Renderer process just crashed.

We have failed the current spec but will continue running the next spec.

failure looks unrelated to changes

@asikowitz asikowitz merged commit 1401fad into datahub-project:master Jul 29, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kartikey-visa @asikowitz @chriscollins3456 @david-leifker