Skip to content

Conversation

benjiaming
Copy link
Contributor

Summary

  • Replace Product Tour on the Homepage with a new Welcome modal.
  • Add Carousel, LoadedImage and LoadedVideo component to Alchemy.
First Slide Last Slide
Screenshot 2025-07-24 at 7 43 44 PM Screenshot 2025-07-24 at 7 43 54 PM

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 25, 2025
Copy link

alwaysmeticulous bot commented Jul 25, 2025

✅ Meticulous spotted visual differences in 368 of 1362 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit c83ab97. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 25, 2025

Bundle Report

Changes will increase total bundle size by 4.78MB (21.39%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
datahub-react-web-esm 27.14MB 4.78MB (21.39%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 13.82kB 18.7MB 0.07%
assets/FTE-*.mp4 (New) 1.23MB 1.23MB 100.0% 🚀
assets/FTE-*.mp4 (New) 1.21MB 1.21MB 100.0% 🚀
assets/FTE-*.mp4 (New) 1.19MB 1.19MB 100.0% 🚀
assets/welcome-*.png (New) 1.14MB 1.14MB 100.0% 🚀
assets/FTE-*.js (New) 64 bytes 64 bytes 100.0% 🚀
assets/FTE-*.js (New) 64 bytes 64 bytes 100.0% 🚀
assets/FTE-*.js (New) 65 bytes 65 bytes 100.0% 🚀

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Carousel/Carousel.tsx → Total Size: 3.02kB

  • ./src/app/onboarding/OnboardingTour.tsx → Total Size: 2.24kB

  • ./src/app/homeV2/HomePage.tsx → Total Size: 1.61kB

  • ./src/app/onboarding/OnboardingTourContext.hooks.ts → Total Size: 773 bytes

  • ./src/app/onboarding/WelcomeToDataHubModal.tsx → Total Size: 11.29kB

  • ./src/app/analytics/event.ts → Total Size: 12.04kB

  • ./src/app/entityV2/shared/constants.ts → Total Size: 5.88kB

  • ./src/alchemy-components/components/LoadedImage/LoadedImage.tsx → Total Size: 1.93kB

  • ./src/app/homeV2/layout/navBarRedesign/NavSidebar.tsx → Total Size: 9.54kB

  • ./src/app/onboarding/WelcomeToDataHubModal.components.tsx → Total Size: 2.52kB

  • ./src/app/onboarding/OnboardingTourContext.tsx → Total Size: 65 bytes

  • ./src/app/AppProviders.tsx → Total Size: 870 bytes

  • ./src/alchemy-components/components/LoadedVideo/LoadedVideo.components.tsx → Total Size: 2.25kB

  • ./src/app/onboarding/OnboardingTourContextProvider.tsx → Total Size: 774 bytes

Copy link

codecov bot commented Jul 25, 2025

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
3241 11 3230 41
View the full list of 3 ❄️ flaky tests
tests.lineage.test_lineage_sdk::test_filtered_column_level_lineage

Flake rate in main: 10.13% (Passed 142 times, Failed 16 times)

Stack Traces | 0.02s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f6440633f10>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_filtered_column_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        filtered_column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            source_column="id",
            direction="downstream",
            max_hops=3,
            filter=F.and_(F.platform("mysql"), F.entity_type("dataset")),
        )
    
>       assert len(filtered_column_lineage_results) == 1
E       assert 0 == 1
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:185: AssertionError
tests.lineage.test_lineage_sdk::test_column_level_lineage_from_schema_field

Flake rate in main: 10.13% (Passed 142 times, Failed 16 times)

Stack Traces | 0.022s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f6440633f10>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_column_level_lineage_from_schema_field(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        source_schema_field = SchemaFieldUrn(test_datasets["upstream"].urn, "id")
        column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(source_schema_field), direction="downstream", max_hops=3
        )
    
>       assert len(column_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:203: AssertionError
tests.lineage.test_lineage_sdk::test_table_level_lineage

Flake rate in main: 10.13% (Passed 142 times, Failed 16 times)

Stack Traces | 0.153s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f6440633f10>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_table_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        table_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            direction="downstream",
            max_hops=3,
        )
    
>       assert len(table_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:109: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant