Skip to content

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Jul 25, 2025

Title to highlight on hover ✅ (3rd commit)
Logic of expansion of collapse on warnings and errors ✅ (2nd commit)
Errors should not automatically expand ✅
Don't show warnings? ✅ (2nd commit)
Logs should have scrolls ✅
Font sizes are off ✅
Text needs to be the proper grays either colors.gray[600] or [1700] ✅
Margins or spacing between headers ✅
Spacing between header and subheader? ✅
Remove extra div in recipe tab at the top? ✅
Remove close button ✅
Inaccessible text for description ✅
Remove divs between sections in modals ✅
Use Accordian for Errors and Warnings and the same announcments component that Chris used for the home page ✅ (2nd commit)
except the proper colors like yellow or red ✅ (2nd commit)
Spacing between sections etc ✅
Use proper card components (they are in stats) for the quick metrics ✅
Something about the math is not mathing in the cards? ✅
View more button padding is off and using an old button and download ✅

Copy link

alwaysmeticulous bot commented Jul 25, 2025

🔴 Meticulous spotted visual differences in 56 of 1401 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 4e045e8. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 25, 2025

Bundle Report

Changes will increase total bundle size by 975 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.36MB 975 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 975 bytes 18.69MB 0.01%

Files in assets/index-*.js:

  • ./src/app/ingestV2/executions/components/SummaryTab.tsx → Total Size: 4.5kB

  • ./src/app/ingestV2/executions/components/reporting/StructuredReport.tsx → Total Size: 6.01kB

  • ./src/app/ingestV2/executions/components/reporting/StructuredReportItemList.tsx → Total Size: 433 bytes

  • ./src/app/ingestV2/source/IngestedAssets.tsx → Total Size: 8.26kB

  • ./src/app/ingestV2/executions/components/BaseTab.tsx → Total Size: 512 bytes

  • ./src/app/ingestV2/source/utils.ts → Total Size: 12.79kB

  • ./src/app/ingestV2/executions/components/LogsTab.tsx → Total Size: 1.4kB

  • ./src/app/ingestV2/source/IngestionSourceTable.tsx → Total Size: 3.87kB

  • ./src/app/ingestV2/executions/components/RecipeTab.tsx → Total Size: 1.63kB

  • ./src/app/ingestV2/executions/components/ExecutionDetailsModal.tsx → Total Size: 2.49kB

  • ./src/app/ingestV2/executions/components/reporting/StructuredReportItem.tsx → Total Size: 1.7kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 26, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jul 28, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jul 28, 2025
Copy link

codecov bot commented Jul 29, 2025

@anshbansal anshbansal merged commit af98667 into master Jul 29, 2025
21 of 24 checks passed
@anshbansal anshbansal deleted the ingestion-modal-followup-fixse branch July 29, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-pending-ci A PR that has passed review and should be merged once CI is green. needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants