-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(ingestion modal): stylistic fixes for ingestion modal #14236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Meticulous spotted visual differences in 56 of 1401 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 4e045e8. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 975 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Title to highlight on hover ✅ (3rd commit)
Logic of expansion of collapse on warnings and errors ✅ (2nd commit)
Errors should not automatically expand ✅
Don't show warnings? ✅ (2nd commit)
Logs should have scrolls ✅
Font sizes are off ✅
Text needs to be the proper grays either colors.gray[600] or [1700] ✅
Margins or spacing between headers ✅
Spacing between header and subheader? ✅
Remove extra div in recipe tab at the top? ✅
Remove close button ✅
Inaccessible text for description ✅
Remove divs between sections in modals ✅
Use Accordian for Errors and Warnings and the same announcments component that Chris used for the home page ✅ (2nd commit)
except the proper colors like yellow or red ✅ (2nd commit)
Spacing between sections etc ✅
Use proper card components (they are in stats) for the quick metrics ✅
Something about the math is not mathing in the cards? ✅
View more button padding is off and using an old button and download ✅