feat(ingest/tableau): enable extract_lineage_from_unsupported_custom_sql_queries by default #14717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sql_queries by default
github-actions
bot
added
the
ingestion
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
There was a problem hiding this comment.
Even if this is an experimental feature, this should be announced as an breaking change in the updating-datahub.md docs.
Also we may take this as the opportunity to improve the description of these flags: what does "doesn't return any metadata" or "ignoring Tableau metadata" mean? do we refer to some specific API?
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only takes effect when Tableau itself returns no lineage, so it's strictly better than having it disabled.