XRD Block Improvement #1263
Open
XRD Block Improvement #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
- Coverage 74.59% 74.34% -0.26%
==========================================
Files 67 67
Lines 4539 4615 +76
==========================================
+ Hits 3386 3431 +45
- Misses 1153 1184 +31
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/xrd-improvement
|
| Run status |
|
| Run duration | 08m 00s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
This was
linked to
issues
Jul 1, 2025
ml-evs
force-pushed
the
bc/xrd-improvement
branch
from
4e3d0f4 to
5d724e0
Compare
ml-evs
reviewed
Jul 9, 2025
There was a problem hiding this comment.
As discussed earlier, this looks really great @BenjaminCharmes! Just a few comments I'd like to address (or at least discuss) before merging.
Co-authored-by: Matthew Evans <git@ml-evs.science>
ml-evs
force-pushed
the
bc/xrd-improvement
branch
from
7ddd609 to
c2ac3fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1260
Closes #1262, #1264, #1265, #1266 & #1267
All these features (except "Ability to stagger rather than overlap patterns") are added to all blocks using BokehPlot. Should it be available only for XRD? Or should also consider adding the stagger option to other blocks as well?
About 'long file names ruin the layout' in #1267, I also set a 15-character limit for the legend.