Lift serialization outside of system DB #180
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts the encoding/decoding of workflows and steps input/outputs outside of the system database, to facilitate further work on serialization. We also make sure to store nil pointers as NULL in Postgres (otherwise an empty string per gob/json + b64 encoding), so we can always return the right value to users (specifically on the
ListWorkflowsandGetWorkflowStepspath which do not have type information for automatic recasting.)The system DB functions thus always return pointers to (encoded) strings.
Note that sleep must still call (de)serialize, when reading/writing the wake up time. This won't be a problem because the type is well known. (We could decide to have an independent encoding and/or no encoding for this, but I don't want to introduce heterogeneity in the encoded data living in the DB.)