Skip to content

Conversation

Eromtap
Copy link

@Eromtap Eromtap commented Nov 25, 2024

resolves #233

Description & motivation

Base model creation would not accept more than one table name. Altered base_model_creation.sh to iterate thru args and call generate_base_model macro for each one.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Base model creation would not accept more than one table name. Altered base_model_creation.sh to iterate thru args and call generate_base_model macro for each one
Corrected bash command to work with new base_model_creation.sh
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 25, 2024
@dbeatty10
Copy link
Contributor

I like the way you are thinking @Eromtap 🤩

Could you open a feature request for this here?

@dbeatty10 dbeatty10 changed the title Base model creation fix Allow base model creation to take multiple tables as arguments Dec 5, 2024
@dbeatty10
Copy link
Contributor

@Eromtap This bash script was originally added in #83, and it was intended to pair up with the create_base_models macro.

Do you know if a command like this would still work after your proposed changes?

dbt run-operation codegen.create_base_models --args '{"source_name": "dbt_dbeatty", "tables": ["raw_orders", "raw_customers", "asdfasdf"]}'

@dbeatty10 dbeatty10 requested a review from a team as a code owner March 3, 2025 21:07
Copy link

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files. Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow base model creation to take multiple tables as arguments

3 participants