Skip to content

Conversation

@stasadev
Copy link
Member

@stasadev stasadev commented Nov 1, 2025

The Issue

Could it be indicated somehow, when another backend than Redis is in use, like changing CLI wording to valkey:6379> ... or maybe it's not really possible?

How This PR Solves The Issue

Adds override for the container hostname.

Manual Testing Instructions

ddev add-on get https://github.com/ddev/ddev-redis/tarball/20251101_stasadev_hostname
ddev redis-backend valkey
ddev restart

ddev redis-cli
# see valkey:6379>

ddev describe
# see backend and pass

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev force-pushed the 20251101_stasadev_hostname branch 2 times, most recently from f8043b8 to 24f28f9 Compare November 1, 2025 10:43
@stasadev stasadev force-pushed the 20251101_stasadev_hostname branch from 24f28f9 to a482d9a Compare November 1, 2025 10:44
@gitressa
Copy link

gitressa commented Nov 1, 2025

Thanks for a fast solution @stasadev! It works perfectly, and valkey:6379> is now shown in the command line.

To put the cherry on top, backend could be included under ddev describe? If you agree, it could also be mentioned in the README under Usage:

Usage

Command Description
[...] [...]
ddev describe View service status, used ports, and backend for Redis
$ ddev describe
┌────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Project: drupal10 ~/dev/drupal10 https://drupal10.ddev.site                                                │
│ Docker platform: linux-docker                                                                              │
│ Router: traefik                                                                                            │
│ DDEV version: v1.24.8                                                                                      │
├──────────────┬──────┬─────────────────────────────────────────────────────────────────┬────────────────────┤
│ SERVICE      │ STAT │ URL/PORT                                                        │ INFO               │
├──────────────┼──────┼─────────────────────────────────────────────────────────────────┼────────────────────┤
│ web          │ OK   │ https://drupal10.ddev.site                                      │ drupal11 PHP 8.3   │
│              │      │ InDocker -> Host:                                               │ Server: nginx-fpm  │
│              │      │  - web:80 -> 127.0.0.1:32816                                    │ Docroot: 'web'     │
│              │      │  - web:443 -> 127.0.0.1:32817                                   │ Perf mode: none    │
│              │      │  - web:8025 -> 127.0.0.1:32818                                  │ Node.js: 22        │
├──────────────┼──────┼─────────────────────────────────────────────────────────────────┼────────────────────┤
│ redis        │ OK   │ InDocker:                                                       │ Backend: Valkey    │
│              │      │  - redis:6379                                                   │                    │

@stasadev
Copy link
Member Author

stasadev commented Nov 1, 2025

Good idea, but we need to wait for v1.24.9 to include that in ddev describe.

I'll hold off on pulling this PR until then (I'll make a new release in a few days) so I can add that change.

@gitressa
Copy link

gitressa commented Nov 1, 2025

Sounds great, I am looking forward to the next release, and even more improvements.

@stasadev stasadev changed the title feat: change redis container hostname with env feat: change redis container hostname with env, show details in ddev describe, update constraint to v1.24.10 Nov 5, 2025
@stasadev stasadev merged commit b50ac77 into main Nov 5, 2025
20 checks passed
@stasadev stasadev deleted the 20251101_stasadev_hostname branch November 5, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants