Fix for issue #35: OutOfMemoryError in MaterialShowcaseView.onDraw #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mask from the ShowcaseView class to prevent additional memory retention and eventuall OOMEs. Now onDraw uses the passed-in canvas and nothing else - though this did come at the cost of having to disable hardware acceleration for this view, it doesn't seem to have any performance drawbacks.
|
This really is a better way of doing the clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed references to a second canvas and a bitmap for the background mask from the ShowcaseView class to prevent additional memory retention and eventual OOMEs. Now onDraw uses the passed-in canvas and nothing else - though this did come at the cost of having to disable hardware acceleration for this view, it doesn't seem to have any performance drawbacks.
I attached two screenshots from Crashlytics of an app I'm working on, first one from the initial release which included MaterialShowcaseView, the second one from the following release where I applied this fix.
It went from the top crash cause to completely disappearing from the list.