Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Conversation

kg0r0
Copy link
Contributor

@kg0r0 kg0r0 commented Apr 10, 2020

Fixed #21

Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awoie who's the best one at uPort to look at this and make sure it won't break anything for you guys?

@kdenhartog
Copy link
Contributor

just noting, I'll bring this up on the next DID-Auth call, so we can get this through ASAP without breaking anyone. When this was discussed in the Aries WG, we recognized it was a breaking change but accepted "everyone" (that we know of at least) would move in that direction. The one who I'm thinking may depend on this package is uPort which is why I want to make sure they have someone aware of this.

@kg0r0
Copy link
Contributor Author

kg0r0 commented Apr 17, 2020

Thank you for your reply.
I will add a commit to resolve the conflicts.

@awoie
Copy link
Member

awoie commented Apr 17, 2020

@awoie who's the best one at uPort to look at this and make sure it won't break anything for you guys?

From our end @mirceanis will be mostly involved in everything that is related to the DIDComm implementation. We should be fine with this PR but let's discuss on the next DID Auth Call.

@kg0r0
Copy link
Contributor Author

kg0r0 commented May 7, 2021

@awoie @kdenhartog
Hi! What is the status of the confirmation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Base64URL encoding used (should not use padding)

3 participants