Skip to content

Conversation

jkroll-deepgram
Copy link
Contributor

Proposed changes

Types of changes

What types of changes does your code introduce to the Deepgram self-hosted resources?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • Please describe your testing setup and methodology here
  • I have added necessary documentation (if appropriate)

Further comments

@bd-g
Copy link
Collaborator

bd-g commented Sep 11, 2025

While we’re at it, we should do this for both API and Engine. (We shouldn’t do for License proxy, fields aren’t added there on any sort of regular basis, so keeping it locked to a set of managed fields is reasonable IMO)

Copy link
Collaborator

@bd-g bd-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We should add this parameter to the values.yaml file as well with an appropriate description so this option is properly documented, and then run helm docs to regenerate the README.

@jkroll-deepgram
Copy link
Contributor Author

We should add this parameter to the values.yaml file as well with an appropriate description so this option is properly documented, and then run helm docs to regenerate the README.

Thanks @bd-g, done: 8b13dc0

@jkroll-deepgram jkroll-deepgram changed the title Enable addition of custom Engine TOML sections Enable addition of custom API and Engine TOML sections Sep 15, 2025
@jkroll-deepgram jkroll-deepgram merged commit eb81ae2 into main Sep 15, 2025
2 checks passed
@jkroll-deepgram jkroll-deepgram deleted the julia/custom-engine-toml branch September 15, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants