Skip to content

Conversation

brianrudolf
Copy link
Contributor

@brianrudolf brianrudolf commented Sep 15, 2025

Proposed changes

Allow null or an empty string to be set for the engine CPU and memory limits to avoid setting limits on these containers.

Resolves #92

Types of changes

What types of changes does your code introduce to the Deepgram self-hosted resources?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • Tested by deploying from local chart, upgrading from a previously deployed chart.
    • Values files updated to set:
engine:
 resources:
   limits:
     cpu: null
     memory: ""
  • helm diff output
         resources:
           requests:
             memory: "20Gi"
             cpu: "6"
             nvidia.com/gpu: 1
           limits:
-             memory: "40Gi"
-             cpu: "8000m"
             nvidia.com/gpu: 1
  • I have added necessary documentation (if appropriate)
    • I ran helm-docs locally but there was no change

Further comments

@brianrudolf brianrudolf marked this pull request as ready for review September 15, 2025 18:26
@jkroll-deepgram jkroll-deepgram merged commit ce551b0 into deepgram:main Sep 17, 2025
2 checks passed
@jkroll-deepgram
Copy link
Contributor

@brianrudolf thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support removing resource limits on engine pods

2 participants