Skip to content

Conversation

@YukariChiba
Copy link
Member

No description provided.

@deepin-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hudeng-go for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


## 动机

目前,deepin 官方仓库未提供 electron 运行时软件包,debian 社区也没有打包 electron 运行时。这意味着,依赖 electron 运行的应用程序如果要在 deepin 上发布,通常需要自行捆绑 electron 运行时,或者要求用户自行安装,这会带来以下问题:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果要在 deepin 上发布

那些自己独立分发的软件一般还是会主动附带一份electron,我们可能只能让希望在我们源/仓库内提供的软件包,或者刻意针对我们进行适配的软件包可以使用我们提供的electron


### 3. electron 应用程序打包方式

应用程序开发者在打包时,须在其 `debian/control` 文件中明确声明对特定主版本运行时的依赖,例如 `Depends: electron29`。软件包内容应仅包含应用自身代码与资源(如 `app.asar`),不再捆绑 electron 二进制文件。应用的启动脚本需相应修改,以调用系统路径下的共享运行时,例如 `exec /usr/bin/electron29 /usr/lib/app-name/ "$@"`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
应用程序开发者在打包时,须在其 `debian/control` 文件中明确声明对特定主版本运行时的依赖,例如 `Depends: electron29`。软件包内容应仅包含应用自身代码与资源(如 `app.asar`),不再捆绑 electron 二进制文件。应用的启动脚本需相应修改,以调用系统路径下的共享运行时,例如 `exec /usr/bin/electron29 /usr/lib/app-name/ "$@"`
应用程序开发者在打包时,须在其 `debian/control` 文件中明确声明对特定主版本运行时的依赖,例如 `Depends: electron-29`。软件包内容应仅包含应用自身代码与资源(如 `app.asar`),不再捆绑 electron 二进制文件。应用的启动脚本需相应修改,以调用系统路径下的共享运行时,例如 `exec /usr/bin/electron29 /usr/lib/app-name/ "$@"`


### 3. electron 应用程序打包方式

应用程序开发者在打包时,须在其 `debian/control` 文件中明确声明对特定主版本运行时的依赖,例如 `Depends: electron29`。软件包内容应仅包含应用自身代码与资源(如 `app.asar`),不再捆绑 electron 二进制文件。应用的启动脚本需相应修改,以调用系统路径下的共享运行时,例如 `exec /usr/bin/electron29 /usr/lib/app-name/ "$@"`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该不是强制吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants