Skip to content

Conversation

@saltenasl
Copy link
Contributor

@saltenasl saltenasl commented Nov 25, 2025

Summary by CodeRabbit

Release Notes

  • Revert

    • Removed feature flags module and its public API. Feature flag checking and variant retrieval functionality are no longer available.
  • Tests

    • Removed unit tests for feature flag functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@linear
Copy link

linear bot commented Nov 25, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

📝 Walkthrough

Walkthrough

This pull request removes the feature flags module and its corresponding tests. The deleted deepnote_toolkit/feature_flags.py contained a cached function to fetch feature flags from the userpod API and two public accessors: is_flag_enabled() to check boolean flags and get_flag_variant() to retrieve string variants. Both accessors fell back to default values on missing or type-mismatched flags. The removal also deletes tests/unit/test_feature_flags.py, which contained comprehensive unit tests covering fetch logic, error handling, caching behavior, and default value scenarios.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately describes the main change: removal of unused feature flag functions from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3afc8fa and c7878cb.

📒 Files selected for processing (2)
  • deepnote_toolkit/feature_flags.py (0 hunks)
  • tests/unit/test_feature_flags.py (0 hunks)
💤 Files with no reviewable changes (2)
  • tests/unit/test_feature_flags.py
  • deepnote_toolkit/feature_flags.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.13
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.9
  • GitHub Check: Test - Python 3.13
  • GitHub Check: Test - Python 3.10

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

📦 Python package built successfully!

  • Version: 1.1.5.dev3+7a767e6
  • Wheel: deepnote_toolkit-1.1.5.dev3+7a767e6-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.5.dev3%2B7a767e6/deepnote_toolkit-1.1.5.dev3%2B7a767e6-py3-none-any.whl"

@saltenasl saltenasl marked this pull request as ready for review November 25, 2025 13:31
@saltenasl saltenasl requested a review from a team as a code owner November 25, 2025 13:31
@saltenasl saltenasl requested review from FilipPyrek and hc2p November 25, 2025 13:31
@deepnote-bot
Copy link

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-39
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-11-25 13:31:50 (UTC)
📜 Deployed commit a84ba123cb35ee0d5d89a8135f00f0b741fd8a38
🛠️ Toolkit version 7a767e6

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.75%. Comparing base (3afc8fa) to head (c7878cb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   72.92%   72.75%   -0.17%     
==========================================
  Files          94       93       -1     
  Lines        5175     5143      -32     
  Branches      755      752       -3     
==========================================
- Hits         3774     3742      -32     
  Misses       1157     1157              
  Partials      244      244              
Flag Coverage Δ
combined 72.75% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saltenasl saltenasl merged commit 4d48a52 into main Nov 25, 2025
34 of 35 checks passed
@saltenasl saltenasl deleted the lukas/grn-5125-clean-up-feature-toggle-logic-in-toolkit branch November 25, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants