Skip to content

Conversation

@Piaskun
Copy link

@Piaskun Piaskun commented Mar 13, 2024

obj_vol.io_limit_policy.name was set to id instead of name

Description

A few sentences describing the overall goals of the pull request's commits.

Details in [BUG]: In volume details, io_limit_policy dictionary in key 'name' is holding 'id' value. #43

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#43

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

obj_vol.io_limit_policy.name was set to id instead of name
@Piaskun
Copy link
Author

Piaskun commented Jul 1, 2024

Hello, is there any chance to review this small change? Thanks in advance!

@anupamaloke
Copy link
Collaborator

@Piaskun, thank you for submitting this PR. Changes look good. We will get it merged as soon as possible. Apologies for the delay.

@anupamaloke
Copy link
Collaborator

@Bhavneet-Sharma, @trisha-dell, could you please review the PR and provide your approval if everything looks good.

Copy link

@dbrennand dbrennand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anupamaloke anupamaloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anupamaloke anupamaloke removed the request for review from Pavan-Mudunuri August 29, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants