-
Notifications
You must be signed in to change notification settings - Fork 51
Fix: Zig version update #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,9 +9,13 @@ | |||||||
| "type": "string", | ||||||||
| "proposals": [ | ||||||||
| "latest", | ||||||||
| "0.10.0" | ||||||||
| "lts", | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| "0.15.2", | ||||||||
| "0.14.1", | ||||||||
| "0.13.0", | ||||||||
| "0.12.1" | ||||||||
| ], | ||||||||
| "default": "latest", | ||||||||
| "default": "lts", | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| "description": "Select the Zig version you would like to install" | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We provide more context here, for example:
Suggested change
|
||||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -36,8 +36,11 @@ mkdir -p /usr/local/lib/zig | |||||
|
|
||||||
| INDEX_URL="https://ziglang.org/download/index.json" | ||||||
|
|
||||||
| if [[ "$ZIG_VERSION" == "latest" || "$ZIG_VERSION" == "current" || "$ZIG_VERSION" == "lts" ]] | ||||||
| if [[ "$ZIG_VERSION" == "latest" || "$ZIG_VERSION" == "current" ]] | ||||||
| then | ||||||
| # for latest we download the latest *release* version | ||||||
| DOWNLOAD_URL=$(curl -sSL $INDEX_URL | jq -r 'to_entries[0].value."'"$ARCH"'-linux".tarball') | ||||||
| elif [[ "$ZIG_VERSION" == "lts" ]]; then | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| # for latest we download the latest *release* version | ||||||
| DOWNLOAD_URL=$(curl -sSL $INDEX_URL | jq -r 'to_entries[1].value."'"$ARCH"'-linux".tarball') | ||||||
| else | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are keeping a single option here, you can reuse its description from
src/zig/devcontainer-feature.json. Following example change from this comment: