Skip to content

Refactor to vz2 and ic1 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Refactor to vz2 and ic1 #7

wants to merge 29 commits into from

Conversation

jbusecke
Copy link
Collaborator

@jbusecke jbusecke commented Jul 21, 2025 •
edited
Loading

Towards #3

  • I just noticed that uv is maintaining a bunch of pre-commit hooks. I should probably prefer these over my custom stuff!
  • I want to explore if persisting the config to storage makes sense in this contex (I will test this on a synth example but would be applied to a potential rewrite of the store)
    • Depending on the findings here, I could raise an issue on vz to add a 'persist_to_storage' flag to vds.vz.to_icechunk.

abarciauskas-bgse and others added 29 commits June 21, 2025 09:01
@abarciauskas-bgse
Fix import
f47377e
@abarciauskas-bgse
Fix some dates and calling write_to_icechunk
872fb37
@abarciauskas-bgse
Add testing notebook
2983fef
@abarciauskas-bgse
Switch to scheduled run
ea999eb
@abarciauskas-bgse
Add testing notebook
34c7d77
@abarciauskas-bgse
Fix merge conflicts
b0ebcc6
@abarciauskas-bgse
testing
859ae54
@abarciauskas-bgse
merge updates
6edf747
@abarciauskas-bgse
Bump memory and timeout
5cc5b59
Bunch of stuff that does not work
91e1ee0
Added branching + tests
e358ad8
testing all timesteps
1a79b0f
reactivated secrets injection + set dry run globally + reduce memory
97c3ded
Pin ic<1.0.0 and vz <2.0.0
935ec16
pin vz 1.3.2 and add more flexibility for local testing re secrets
554993a
stricter requirments + fix for the local testing logic
0130edd
Revert local dev if statement
1b8d5a4
More logging
a9c6c14
fix requirements
4918dfd
Add prints + load data before try except
8f1d6bb
switch direct links to external
e2b1fed
add h5netcdf to requirements
4810008
remove global dry_run env var
1b04dc6
mergecommit
838f36f
Improved print messages
f7357bf
Migrated to uv + post-commit hook to sync lambda reqs
4b4a6b5
clean requirements.txt output
df0d6e3
Add instructions for notebook testing + when I encountered error desc…
8144153 
…ribed in issue 7
Updated ic and vz versions
1970025
@jbusecke jbusecke mentioned this pull request Jul 21, 2025
Open
@jbusecke
Copy link
Collaborator Author

As part of my discussion with @maxrjones earlier, I will proceed here, and potentially do a complete rewrite of the store using the new dependencies in the hopes that might solve #6 and #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbusecke @abarciauskas-bgse