REAME and CONTRIBUTING updates #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
ibuziuk
reviewed
Nov 12, 2024
Contributor
ibuziuk
left a comment
ibuziuk
left a comment
There was a problem hiding this comment.
Great contribution, thank you!
ibuziuk
approved these changes
Nov 12, 2024
dkwon17
requested changes
Nov 12, 2024
dkwon17
approved these changes
Nov 12, 2024
Collaborator
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Collaborator
Author
dkwon17
approved these changes
Nov 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, ibuziuk, l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
docs/dwo-configuration.mdCONTRIBUTING.mdWhat issues does this PR fix or reference?
#1334
Is it tested? How?
The instructions in the new section have been tested on developer sandbox.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che